fix: resolve failing tests and type errors across api and shared packages#54
Open
stooit wants to merge 1 commit into
Open
fix: resolve failing tests and type errors across api and shared packages#54stooit wants to merge 1 commit into
stooit wants to merge 1 commit into
Conversation
…ages - auth middleware: fix case-sensitive HTTP method check so POST /users is public - users route: import missing badRequest error helper (was 500, now 400) - shared types: rename User.userName -> username to match consumers - shared: implement paginate() utility (was a stub) with page clamping - tsconfig: wire up bun/node types to resolve process and bun:test errors
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes all failing tests and TypeScript errors in the multi-package repo. Final state: 22/22 tests pass,
tsc --noEmitreports 0 errors.Bugs fixed
packages/api/src/middleware/auth.ts) — the public-methods check compared against"post"while Hono supplies"POST", soPOST /userswas wrongly treated as protected (401 instead of 201). Fixed the comparison.packages/api/src/routes/users.ts) —badRequestwas used but never imported, causing aReferenceError(500 instead of 400). Added it to the import from../lib/errors.packages/shared/src/types.ts) —User.userNamewas renamed tousernameto match the route handlers and tests.packages/shared/src/utils/pagination.ts) — implemented thepaginate()stub to satisfy the full contract (slicing,total,totalPages,page/pageSize, empty arrays, out-of-range pages), withMath.max(1, Math.floor(page))page clamping.tsconfig.json) — wired up the already-installed bun/node types soprocessandbun:testresolve.Constraints honoured
Verification
bun test→ 22 pass / 0 failnpx tsc --noEmit→ exit 0, no errors